Disallow Self Compare (no-self-compare)


Comparing a variable against itself is usually an error, either a typo or refactoring error. It is confusing to the reader and may potentially introduce a runtime error.


The only time you would compare a variable against itself is when you are testing for NaN. However, it is far more appropriate to use typeof x === 'number' && isNaN(x) or the Number.isNaN ES2015 function for that use case rather than leaving the reader of the code to determine the intent of self comparison.

唯一肯能会对变量自身做比较时候是当你在测试变量是否是 NaN。然而,在这种情况下,更适合使用 typeof x === 'number' && isNaN(x) 或者 Number.isNaN ES2015 函数 而不是变量自身比较。

Rule Details

This error is raised to highlight a potentially confusing and potentially pointless piece of code. There are almost no situations in which you would need to compare something to itself.


Examples of incorrect code for this rule:

错误 代码示例:

/*eslint no-self-compare: "error"*/

var x = 10;
if (x === x) {
    x = 20;

Further Reading


This rule was introduced in ESLint 0.0.9.

该规则在 ESLint 0.0.9 中被引入。